-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: bundle splitting #13
feat!: bundle splitting #13
Conversation
# Conflicts: # knip.ts # src/utils/helpers.ts # tests/generate-erc721-permit.test.ts
b44cc1c
to
ae6866f
Compare
# Conflicts: # package.json # src/generate-permits-from-context.ts # tests/encode-decode.test.ts # tests/generate-payout-permit.test.ts
Knip complaining for unknown reasons, also happens locally. But there is no unused dependencies, not unused exports in this code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the PR adds vanilla update, looks clean
Let me check the root cause. |
It took me almost 3 hours, which was completely ridiculous but I was able to find and fix this. During a debugging session I discovered that Knip parses .gitignore file! The solution was to add a slash so that only build artifacts are not considered : Time to sleep now, tomorrow i am back to other issues -) |
@gitcoindev thanks a lot for you help. This would mean it happens in every other repository potentially? Or just on this one. |
@gentlementlegen potentially in other repositories as well. The usual place to place build artifacts is |
@gitcoindev Okay I see. The reason why I am not using |
I solved it for There is a good article explaining how this works : https://dev.to/tigawanna/building-and-publishing-npm-packages-with-typescript-multiple-entry-points-tailwind-tsup-and-npm-9e7 You hopefully should be able to achieve similar setup with |
This aims to split the bundle to avoid importing Node modules in places where they are not required. Now the imports can be as such:
@ubiquibot/permit-generation/core
@ubiquibot/permit-generation/types
@ubiquibot/permit-generation/handlers